Always return failure when we didn't manage to add transitions.

Always return failure when we didn't manage to add transitions.

Committed: https://code.google.com/p/v8/source/detail?r=12063

[Toon Verwaest, 2012-07-12 13:22:42]

PTAL. This addresses the comment you had on the separation patch regarding lost
transitions. Now we always return failure if the transition was inadvertently
not added.

[Jakob Kummerow, 2012-07-12 14:38:19]

LGTM with comments.

https://chromiumcodereview.appspot.com/10704183/diff/1/src/isolate.h
File src/isolate.h (right):

https://chromiumcodereview.appspot.com/10704183/diff/1/src/isolate.h#newcode531
src/isolate.h:531: // Access to the map of "new Object()"
nit: Comments should be sentences with one or more verbs and appropriate
punctuation (such as a trailing full stop).

https://chromiumcodereview.appspot.com/10704183/diff/1/src/isolate.h#newcode532
src/isolate.h:532: Map* global_object_map() {
The name is misleading. "empty_object_map" would be better, to emphasize that
this is not the map of the global object.

https://chromiumcodereview.appspot.com/10704183/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10704183/diff/1/src/objects.cc#newcode...
src/objects.cc:1627: // Do not add transitions to objects with the global object
map, nor to global
for clarity:
"Do not add transitions to empty object maps, nor to the global object."
See my other comment for "global object map" vs. "empty object map"; and there's
only one global object.

https://chromiumcodereview.appspot.com/10704183/diff/1/src/objects.cc#newcode...
src/objects.cc:1634: // Don't add transitions to special properties, with
non-trival attributes.
nit: "trivial", and the comma is unnecessary.

https://chromiumcodereview.appspot.com/10704183/diff/1/src/objects.cc#newcode...
src/objects.cc:1794: // If we get to this point we have succeeded - do not
return failure
Outdated comment. Just remove it.

https://chromiumcodereview.appspot.com/10704183/diff/1/src/objects.cc#newcode...
src/objects.cc:1850: FixedArray* new_properties = NULL;  // Will always be NULL
or a valid pointer.
You can remove the initialization and the comment (we don't have them in other
places either).