Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10704175: Add config change support to FFmpegVideoDecoder (Closed)

Created:
8 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add config change support to FFmpegVideoDecoder BUG=122913 TEST=None

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -38 lines) Patch
M media/base/video_frame.h View 5 chunks +21 lines, -0 lines 1 comment Download
M media/base/video_frame.cc View 5 chunks +26 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 2 chunks +9 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 5 chunks +61 lines, -26 lines 2 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/video_renderer_base.cc View 1 chunk +10 lines, -1 line 0 comments Download
M media/mp4/mp4_stream_parser.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
acolwell GONE FROM CHROMIUM
PTAL Relies on the following changes https://chromiumcodereview.appspot.com/10669022/ https://chromiumcodereview.appspot.com/10696182/
8 years, 5 months ago (2012-07-12 01:21:25 UTC) #1
acolwell GONE FROM CHROMIUM
I know I still need to add tests. Just wanted to get all the changes ...
8 years, 5 months ago (2012-07-12 01:24:09 UTC) #2
Ami GONE FROM CHROMIUM
8 years, 5 months ago (2012-07-13 00:59:05 UTC) #3
I don't understand what the natural_size business is all about, and I think it's
strange that even though it's a pretty constant thing, we end up setting it and
looking it up on every single frame.  Maybe f2f convo would help.

https://chromiumcodereview.appspot.com/10704175/diff/1/media/base/video_frame.h
File media/base/video_frame.h (right):

https://chromiumcodereview.appspot.com/10704175/diff/1/media/base/video_frame...
media/base/video_frame.h:53: size_t natural_width,
You need serious commentary about how the "natural_" prefix modifies the meaning
of the parameter.

https://chromiumcodereview.appspot.com/10704175/diff/1/media/filters/ffmpeg_v...
File media/filters/ffmpeg_video_decoder.cc (right):

https://chromiumcodereview.appspot.com/10704175/diff/1/media/filters/ffmpeg_v...
media/filters/ffmpeg_video_decoder.cc:163: if (!AllocateFFmpegResources(config))
{
I wonder if it doesn't make sense to inline AFFMR() into HandleConfigChange and
call the latter from here (and make it tolerant to not having a "previous" set
of ffmpeg resources to release).

https://chromiumcodereview.appspot.com/10704175/diff/1/media/filters/ffmpeg_v...
media/filters/ffmpeg_video_decoder.cc:172: frame_rate_denominator_ =
config.frame_rate_denominator();
...in which case these can go away

Powered by Google App Engine
This is Rietveld 408576698