Issue 10704171: Expected increase in chrome.pak size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704171: Expected increase in chrome.pak size (Closed)

Created:
8 years, 5 months ago by benrg

Modified:
8 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/tools/perf_expectations/

Visibility:
Public.

More Reviews

Description

Expected increase in chrome.pak size See http://codereview.chromium.org/10756018/ BUG=133570 TBR=cmp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146231

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	perf_expectations.json	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

LGTM % it would be nice for the CL description to say why.

8 years, 5 months ago (2012-07-11 22:50:50 UTC) #1

sail

On 2012/07/11 22:50:50, Ami Fischman wrote: > LGTM % it would be nice for the ...

8 years, 5 months ago (2012-07-11 23:10:36 UTC) #2

benrg

8 years, 5 months ago (2012-07-11 23:17:58 UTC) #3

On 2012/07/11 23:10:36, sail wrote:
> On 2012/07/11 22:50:50, Ami Fischman wrote:
> > LGTM % it would be nice for the CL description to say why.
> 
> Also, can we file a M22 bug to fix this? Currently we're duplicating all
> resources in the .rc and .pak file. Once we get rid of the duplication the
> binary size should go back down.

This failure was due to an increase in chrome.pak, not the chrome executable. I
don't think it's a bug, but I'm not sure I understand everything that's going
on. I'll file a bug for the rc+pak problem. There should also be a bug for the
resource duplication in general, but it isn't new to this CL and isn't
necessarily bad (because it improves data locality).

Expand Messages | Collapse Messages