Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3833)

Unified Diff: chrome/browser/chromeos/gdata/gdata_operations.h

Issue 10704158: Revert 146104 - gdrive: Get JSON feeds parsing off the UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_operations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_operations.h
===================================================================
--- chrome/browser/chromeos/gdata/gdata_operations.h (revision 146109)
+++ chrome/browser/chromeos/gdata/gdata_operations.h (working copy)
@@ -191,25 +191,15 @@
virtual ~GetDataOperation();
// Parse GData JSON response.
- virtual bool ParseResponse(GDataErrorCode fetch_error_code,
- const std::string& data);
+ virtual base::Value* ParseResponse(const std::string& data);
protected:
// Overridden from UrlFetchOperationBase.
virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;
- virtual void RunCallbackOnPrematureFailure(
- GDataErrorCode fetch_error_code) OVERRIDE;
+ virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;
- void RunCallback(GDataErrorCode fetch_error_code,
- scoped_ptr<base::Value> value);
-
private:
- void OnDataParsed(GDataErrorCode fetch_error_code,
- scoped_ptr<base::Value>* value);
-
GetDataCallback callback_;
- base::WeakPtrFactory<GetDataOperation> weak_ptr_factory_;
-
DISALLOW_COPY_AND_ASSIGN(GetDataOperation);
};
@@ -450,8 +440,7 @@
// Must override GetDataOperation's ParseResponse because the response is XML
// not JSON.
- virtual bool ParseResponse(GDataErrorCode code,
- const std::string& data) OVERRIDE;
+ virtual base::Value* ParseResponse(const std::string& data) OVERRIDE;
private:
std::string app_id_;
GURL document_url_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_operations.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698