Small refactor to media architecture in order to allow end-to-end tests.

media/audio/mock_audio_manager.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/audio/mock_audio_manager.h"
+
+namespace media {
+
+MockAudioManager::MockAudioManager(content::BrowserThread::ID thread_id)
+    : thread_id_(thread_id) {
+}
+
+MockAudioManager::~MockAudioManager() {
+}
+
+bool MockAudioManager::HasAudioOutputDevices() {
+  return true;
+}
+
+bool MockAudioManager::HasAudioInputDevices() {
+  return true;
+}
+
+string16 MockAudioManager::GetAudioInputDeviceModel() {
+  return string16();
+}
+
+bool MockAudioManager::CanShowAudioInputSettings() {
+  return false;
+}
+
+void MockAudioManager::ShowAudioInputSettings() {
+}
+
+void MockAudioManager::GetAudioInputDeviceNames(
+      media::AudioDeviceNames* device_names) {
+}
+
+media::AudioOutputStream* MockAudioManager::MakeAudioOutputStream(
+        const media::AudioParameters& params) {
+  NOTREACHED();
+  return NULL;
+}
+
+media::AudioOutputStream* MockAudioManager::MakeAudioOutputStreamProxy(
+    const media::AudioParameters& params) {
+  NOTREACHED();
+  return NULL;
+}
+
+media::AudioInputStream* MockAudioManager::MakeAudioInputStream(
+    const media::AudioParameters& params,
+    const std::string& device_id) {
+  NOTREACHED();
+  return NULL;
+}
+
+void MockAudioManager::MuteAll() {
+}
+
+void MockAudioManager::UnMuteAll() {
+}
+
+bool MockAudioManager::IsRecordingInProcess() {
+  return false;
+}
+
+scoped_refptr<base::MessageLoopProxy> MockAudioManager::GetMessageLoop() {
+  return content::BrowserThread::GetMessageLoopProxyForThread(thread_id_);

[tommi (sloooow) - chröme, 2012/07/11 11:12:30]

why don't we pass a pointer to a MessageLoopProxy to the constructor?  This
feels like unnecessarily bringing in BrowserThread dependency when we're really
only interested in a message loop.

[Primiano Tucci (use gerrit), 2012/07/11 14:33:30]

I thought it was more loosely coupled since the thread_id_ is basically an
integer, while holding a (smart)pointer which keeps the MessageLoopProxy
refcounted could have some  side effects?

+}
+
+void MockAudioManager::Init() {
+};

[tommi (sloooow) - chröme, 2012/07/11 11:12:30]

remove semicolon

[Primiano Tucci (use gerrit), 2012/07/11 14:33:30]

Done.

+
+}  // namespace media.