Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10704153: Adjust the all.gyp:All target for iOS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adjust the all.gyp:All target for iOS The initial iOS version was over-ambitious, and doesn't yet build. To get the build working, this: - only builds base:base on iOS, not base:*, and - disables warnings-as-errors in third-party code for iOS, since at least NSS and ICU have warnings for iOS. This also adds nss.gyp to the iOS build, now that its gyp support has landed BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146120

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/all.gyp View 3 chunks +6 lines, -2 lines 3 comments Download
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
8 years, 5 months ago (2012-07-11 06:42:27 UTC) #1
rohitrao (ping after 24h)
https://chromiumcodereview.appspot.com/10704153/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/10704153/diff/1/build/all.gyp#newcode70 build/all.gyp:70: }, { I'm having trouble parsing this gyp file. ...
8 years, 5 months ago (2012-07-11 11:52:31 UTC) #2
stuartmorgan
https://chromiumcodereview.appspot.com/10704153/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/10704153/diff/1/build/all.gyp#newcode70 build/all.gyp:70: }, { On 2012/07/11 11:52:31, rohitrao wrote: > I'm ...
8 years, 5 months ago (2012-07-11 13:49:51 UTC) #3
rohitrao (ping after 24h)
lgtm https://chromiumcodereview.appspot.com/10704153/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/10704153/diff/1/build/all.gyp#newcode70 build/all.gyp:70: }, { Oh, I see. So this is ...
8 years, 5 months ago (2012-07-11 14:01:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10704153/1
8 years, 5 months ago (2012-07-11 14:03:05 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 15:11:26 UTC) #6
Change committed as 146120

Powered by Google App Engine
This is Rietveld 408576698