Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 10704150: Add presubmit check for #pragma once. (Closed)

Created:
8 years, 5 months ago by dcheng
Modified:
8 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews
Visibility:
Public.

Description

Add presubmit check for #pragma once. BUG=none TEST=git cl presubmit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146166

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +20 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
As fun as I think it would be to submit this now, I'll wait for ...
8 years, 5 months ago (2012-07-11 05:26:54 UTC) #1
awong
LGTM w/ one comment Thanks...and yeah...I think waiting for the glut of #pragma once removals ...
8 years, 5 months ago (2012-07-11 05:41:06 UTC) #2
dcheng
8 years, 5 months ago (2012-07-11 05:44:19 UTC) #3
http://codereview.chromium.org/10704150/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/10704150/diff/1/PRESUBMIT.py#newcode371
PRESUBMIT.py:371: 'Do not use #pragma once in header files.\n' +
On 2012/07/11 05:41:06, awong wrote:
> I don't think you need this plus to concat these strings.  In fact, I think if
> you do, you end up making an o(n) copy...

Oops, you're right. I copied this from the iostream check so I'll fix that site
as well.

Powered by Google App Engine
This is Rietveld 408576698