Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 10704149: Set the Feature's ChannelForTesting to Trunk during extension tests, so that (Closed)

Created:
8 years, 5 months ago by Matt Perry
Modified:
8 years, 5 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Set the Feature's ChannelForTesting to Trunk during extension tests, so that they pass on beta/stable builds even if the features are restricted to dev/trunk. BUG=136629 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146156

Patch Set 1 #

Patch Set 2 : trunl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/extensions/extension_browsertest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
8 years, 5 months ago (2012-07-11 01:08:13 UTC) #1
Aaron Boodman
8 years, 5 months ago (2012-07-11 02:57:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698