Issue 10704148: Protect references to ThemeService* with ENABLE_THEMES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704148: Protect references to ThemeService* with ENABLE_THEMES (Closed)

Created:
8 years, 5 months ago by nilesh

Modified:
8 years, 5 months ago

Reviewers:
Yoyo Zhou, Jay Civelli

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Protect references to ThemeService* with ENABLE_THEMES On android, ENABLE_THEMES and ENABLE_PROTECTOR_SERVICE are not defined. This fixes some link errors for unit_tests. BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146028

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
M	chrome/browser/extensions/extension_service.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_system_factory.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10704148/1

8 years, 5 months ago (2012-07-11 00:48:26 UTC) #5

Change committed as 146028