Issue 10704147: Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessag…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704147: Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessag… (Closed)

Created:
8 years, 5 months ago by zysxqn

Modified:
8 years, 5 months ago

Reviewers:
Ilya Sherman, Garrett Casto

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessage, since RenderViewHost can be changed if users navigate to a different site. We have seen crashes (highly possibly) because of this (http://code.google.com/p/chromium/issues/detail?id=134191) BUG=134191 TEST=PasswordFormManagerTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146164

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	chrome/browser/password_manager/password_form_manager.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/password_manager/password_form_manager.cc	View	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/password_manager/password_manager.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@google.com/10704147/1

8 years, 5 months ago (2012-07-11 17:41:53 UTC) #3

Change committed as 146164