Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 10704134: fix clang warnings for chrome on android (Closed)

Created:
8 years, 5 months ago by qinmin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

fix clang warnings for chrome on android variable begin_ and end_ is never being used, and it is generating clang errors BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M net/http/http_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qinmin
8 years, 5 months ago (2012-07-10 17:46:00 UTC) #1
erikwright (departed)
LGTM. cbentzel for the rubberstamp, since Will's on holiday.
8 years, 5 months ago (2012-07-10 18:00:41 UTC) #2
willchan no longer on Chromium
Lgtm from Iceland On Jul 10, 2012 6:00 PM, <erikwright@chromium.org> wrote: > LGTM. > > ...
8 years, 5 months ago (2012-07-10 20:49:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/10704134/1
8 years, 5 months ago (2012-07-10 20:57:00 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 22:36:01 UTC) #5
Change committed as 145970

Powered by Google App Engine
This is Rietveld 408576698