Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9059)

Unified Diff: chrome/test/reliability/automated_ui_test_base.cc

Issue 10704129: Remove browser::FindTabbedBrowser call in ui test code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/perf/mach_ports_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/reliability/automated_ui_test_base.cc
===================================================================
--- chrome/test/reliability/automated_ui_test_base.cc (revision 145676)
+++ chrome/test/reliability/automated_ui_test_base.cc (working copy)
@@ -70,13 +70,17 @@
LogErrorMessage("Application closed unexpectedly.");
return false;
}
- scoped_refptr<BrowserProxy> browser(automation()->FindTabbedBrowserWindow());
- if (!browser.get()) {
- LogErrorMessage("Can't find browser window.");
- return false;
+ for (int i = 0; i < browser_windows_count - 1; ++i) {
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(i));
+ Browser::Type type;
+ if (browser->GetType(&type) && type == Browser::TYPE_TABBED) {
+ set_active_browser(browser);
+ return true;
+ }
}
- set_active_browser(browser);
- return true;
+
+ LogErrorMessage("Can't find browser window.");
+ return false;
}
bool AutomatedUITestBase::DuplicateTab() {
« no previous file with comments | « chrome/test/perf/mach_ports_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698