Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 10704128: Add an option to the tickprocessor to specify the directory for lib lookup (Closed)

Created:
8 years, 5 months ago by remi.duraffort
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git
Visibility:
Public.

Description

Add an option to the tickprocessor to specify the directory for lib lookup This is usefull when generating a profile on one architecture and analyzing it on another architecture or system version. Committed: https://code.google.com/p/v8/source/detail?r=12089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/tickprocessor.js View 4 chunks +6 lines, -1 line 0 comments Download
M tools/tickprocessor-driver.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
remi.duraffort
8 years, 5 months ago (2012-07-10 12:09:46 UTC) #1
remi.duraffort
Any update on this patch ? Thanks.
8 years, 5 months ago (2012-07-16 09:26:32 UTC) #2
Jakob Kummerow
LGTM. I'll land it for you.
8 years, 5 months ago (2012-07-16 10:37:33 UTC) #3
Jakob Kummerow
8 years, 5 months ago (2012-07-16 11:02:55 UTC) #4
Landed. Next time, please also update the Win/Mac specific implementations
(sure, this being JS they would fail somewhat gracefully, and cross-environments
on Win probably aren't supported anyway, but still, having functionality that
works on one platform silently fail on another without so much as documentation
is not good).

Powered by Google App Engine
This is Rietveld 408576698