Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10704127: Revert "Removed one copy-n-paste clone of HGraphBuilder::BuildStoreNamed." (Closed)

Created:
8 years, 5 months ago by Sven Panne
Modified:
8 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Revert "Removed one copy-n-paste clone of HGraphBuilder::BuildStoreNamed." It inadvertently introduced some performance regressions, e.g. for the 'richards' benchmark. Committed: https://code.google.com/p/v8/source/detail?r=12023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -29 lines) Patch
M src/ast.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/hydrogen.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 5 months ago (2012-07-10 08:38:49 UTC) #1
danno
8 years, 5 months ago (2012-07-10 08:55:59 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698