Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: base/sys_info_mac.cc

Issue 10704123: Implement SysInfo for iOS (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/sys_info_ios.mm ('K') | « base/sys_info_ios.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info_mac.cc
diff --git a/base/sys_info_mac.cc b/base/sys_info_mac.cc
index d8210a299932571fd0d41042918daf38e06577e3..2e0df72cf8b4996e4374a4512a07109800293bc4 100644
--- a/base/sys_info_mac.cc
+++ b/base/sys_info_mac.cc
@@ -46,7 +46,10 @@ int64 SysInfo::AmountOfPhysicalMemory() {
HOST_BASIC_INFO,
reinterpret_cast<host_info_t>(&hostinfo),
&count);
- DCHECK_EQ(HOST_BASIC_INFO_COUNT, count);
+ if (count != HOST_BASIC_INFO_COUNT) {
Mark Mentovai 2012/07/10 16:10:04 Again, I asked you to check result before you chec
Chen Yu 2012/07/10 17:07:30 Done.
+ NOTREACHED();
+ return 0;
+ }
if (result != KERN_SUCCESS) {
NOTREACHED();
return 0;
« base/sys_info_ios.mm ('K') | « base/sys_info_ios.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698