Implement SysInfo for iOS

base/sys_info_mac.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 #include <CoreServices/CoreServices.h>
 #include <mach/mach_host.h>
 #include <mach/mach_init.h>
@@ skipping 28 matching lines @@
 }
 
 // static
 int64 SysInfo::AmountOfPhysicalMemory() {
   struct host_basic_info hostinfo;
   mach_msg_type_number_t count = HOST_BASIC_INFO_COUNT;
   int result = host_info(mach_host_self(),
                          HOST_BASIC_INFO,
                          reinterpret_cast<host_info_t>(&hostinfo),
                          &count);
-  DCHECK_EQ(HOST_BASIC_INFO_COUNT, count);
+  if (count != HOST_BASIC_INFO_COUNT) {

[Mark Mentovai, 2012/07/10 16:10:04]

Again, I asked you to check result before you checked count. Instead, you
changed the DCHECK into a live check. I think the DCHECK is fine. In fact, I
prefer it. But you can’t look at count until you’ve made sure that result is
KERN_SUCCESS.

[Chen Yu, 2012/07/10 17:07:30]

Done.

+    NOTREACHED();
+    return 0;
+  }
   if (result != KERN_SUCCESS) {
     NOTREACHED();
     return 0;
   }
 
   return static_cast<int64>(hostinfo.max_mem);
 }
 
 }  // namespace base