runtime/vm/intermediate_language.h - Issue 10704119: Use the instruction iterator rather than an explicit loop in more places.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.h

Issue 10704119: Use the instruction iterator rather than an explicit loop in more places. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.h

diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h

index 2678a881d2ddeb2c353a1064a46eacfe20ef8def..7ad44910141fb4d6f6bc227b57c3763792679e36 100644

--- a/runtime/vm/intermediate_language.h

+++ b/runtime/vm/intermediate_language.h

@@ -1706,7 +1706,7 @@ FOR_EACH_INSTRUCTION(FORWARD_DECLARATION)

// Functions required in all concrete instruction classes.

#define DECLARE_INSTRUCTION(type) \

- virtual Instruction* Accept(FlowGraphVisitor* visitor); \

+ virtual void Accept(FlowGraphVisitor* visitor); \

virtual bool Is##type() const { return true; } \

virtual type##Instr* As##type() { return this; } \

virtual intptr_t InputCount() const; \

@@ -1748,7 +1748,7 @@ class Instruction : public ZoneAllocated {

virtual void SetInputAt(intptr_t i, Value* value) = 0;

// Visiting support.

- virtual Instruction* Accept(FlowGraphVisitor* visitor) = 0;

+ virtual void Accept(FlowGraphVisitor* visitor) = 0;

Instruction* previous() const { return previous_; }

void set_previous(Instruction* instr) {

« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »