Use the instruction iterator rather than an explicit loop in more places.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/flow_graph_builder.h"
 #include "vm/il_printer.h"
 #include "vm/object_store.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, enable_type_checks);
 DECLARE_FLAG(bool, print_flow_graph);
 DECLARE_FLAG(bool, trace_optimization);
 
 void FlowGraphOptimizer::ApplyICData() {
   VisitBlocks();
   if (FLAG_print_flow_graph) {
     OS::Print("After Optimizations:\n");
     FlowGraphPrinter printer(Function::Handle(), block_order_);
     printer.PrintBlocks();
   }
 }
 
 
-void FlowGraphOptimizer::VisitBlocks() {
-  for (intptr_t i = 0; i < block_order_.length(); ++i) {
-    Instruction* instr = block_order_[i]->Accept(this);
-    // Optimize all successors until an exit, branch, or a block entry.
-    while ((instr != NULL) && !instr->IsBlockEntry()) {
-      instr = instr->Accept(this);
-    }
-  }
-}
-
-
 static bool ICDataHasReceiverClassId(const ICData& ic_data, intptr_t class_id) {
   ASSERT(ic_data.num_args_tested() > 0);
   for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {
     const intptr_t test_class_id = ic_data.GetReceiverClassIdAt(i);
     if (test_class_id == class_id) {
       return true;
     }
   }
   return false;
 }
@@ skipping 566 matching lines @@
   TryFuseComparisonWithBranch(instr, comp);
 }
 
 
 void FlowGraphOptimizer::VisitBind(BindInstr* instr) {
   instr->computation()->Accept(this, instr);
 }
 
 
 
-FlowGraphAnalyzer::FlowGraphAnalyzer(
-    const GrowableArray<BlockEntryInstr*>& blocks)
-        :blocks_(blocks), is_leaf_(false) {}
-
-
 void FlowGraphAnalyzer::Analyze() {
   is_leaf_ = true;
   for (intptr_t i = 0; i < blocks_.length(); ++i) {
-    BlockEntryInstr* block_entry = blocks_[i];
-    Instruction* instr = block_entry->next();
-    while ((instr != NULL) && !instr->IsBlockEntry()) {
-      LocationSummary* locs = instr->locs();
-      if (locs != NULL) {
-        if (locs->is_call()) {
-          is_leaf_ = false;
-          return;
-        }
+    BlockEntryInstr* entry = blocks_[i];
+    for (ForwardInstructionIterator it(entry); !it.Done(); it.Advance()) {
+      LocationSummary* locs = it.Current()->locs();
+      if ((locs != NULL) && locs->is_call()) {
+        is_leaf_ = false;
+        return;
       }
-      instr = instr->next();
     }
   }
 }
 
 }  // namespace dart