Use the instruction iterator rather than an explicit loop in more places.

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
@@ skipping 75 matching lines @@
          (FLAG_optimization_counter_threshold >= 0) &&
          !Isolate::Current()->debugger()->IsActive();
 }
 
 
 void FlowGraphCompiler::VisitBlocks() {
   for (intptr_t i = 0; i < block_order().length(); ++i) {
     ASSERT(frame_register_allocator()->IsSpilled());
     assembler()->Comment("B%d", i);
     // Compile the block entry.
-    set_current_block(block_order()[i]);
-    current_block()->PrepareEntry(this);
-    Instruction* instr = current_block()->next();
+    BlockEntryInstr* entry = block_order()[i];
+    set_current_block(entry);
+    entry->PrepareEntry(this);
     // Compile all successors until an exit, branch, or a block entry.
-    while ((instr != NULL) && !instr->IsBlockEntry()) {
+    Instruction* instr = entry;
+    for (ForwardInstructionIterator it(entry); !it.Done(); it.Advance()) {
+      instr = it.Current();
       if (FLAG_code_comments) EmitComment(instr);
       ASSERT(instr->locs() != NULL);
       EmitInstructionPrologue(instr);
       instr->EmitNativeCode(this);
-      instr = instr->next();
     }
-    BlockEntryInstr* successor =
-        (instr == NULL) ? NULL : instr->AsBlockEntry();
-    if (successor != NULL) {
+    if (instr->next() != NULL) {
+      BlockEntryInstr* successor = instr->next()->AsBlockEntry();
+      ASSERT(successor != NULL);
       frame_register_allocator()->Spill();
-      // Block ended with a "goto".  We can fall through if it is the
+      // The block ended with a "goto".  We can fall through if it is the
       // next block in the list.  Otherwise, we need a jump.
       if ((i == block_order().length() - 1) ||
           (block_order()[i + 1] != successor)) {
         assembler()->jmp(GetBlockLabel(successor));
       }
     }
   }
 }
 
 
@@ skipping 500 matching lines @@
 
 
 void FrameRegisterAllocator::SpillInDeoptStub(DeoptimizationStub* stub) {
   for (int i = 0; i < stack_.length(); i++) {
     stub->Push(stack_[i]);
   }
 }
 
 
 }  // namespace dart