Issue 10704118: Clean Up: Gather ibus constants to ibus_constants.h

Issue 10704118: Clean Up: Gather ibus constants to ibus_constants.h (Closed)

Created:
8 years, 5 months ago by Seigo Nonaka

Modified:
8 years, 5 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Clean Up: Gather all ibus constants to ibus_constants.h BUG=None TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146052

Patch Set 2 : Move constants to ibus_constants.h #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -117 lines)			Patch
M	chromeos/dbus/ibus/ibus_client.cc	View	1	3 chunks	+6 lines, -7 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_client_unittest.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_constants.h	View	1	1 chunk	+28 lines, -7 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_input_context_client.cc	View	1	5 chunks	+30 lines, -41 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_input_context_client_unittest.cc	View	1	17 chunks	+80 lines, -58 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

satorux1

I'm confused... Why is this clean-up? Duplicating the same constants into multiple files doesn't sound ...

8 years, 5 months ago (2012-07-10 07:21:40 UTC) #2

Seigo Nonaka

Sure, moved all constants to ibus_constants.h instead of removing it. http://codereview.chromium.org/10704118/diff/1/chromeos/dbus/ibus/ibus_input_context_client.cc File chromeos/dbus/ibus/ibus_input_context_client.cc (right): http://codereview.chromium.org/10704118/diff/1/chromeos/dbus/ibus/ibus_input_context_client.cc#newcode23 ...

8 years, 5 months ago (2012-07-10 08:06:37 UTC) #3