Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6893)

Unified Diff: chrome/browser/process_singleton_browsertest.cc

Issue 10704115: Switch to TimeDelta interfaces of TestTimeouts in chrome and ui code reviewable by ben. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/process_singleton_linux_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/process_singleton_browsertest.cc
diff --git a/chrome/browser/process_singleton_browsertest.cc b/chrome/browser/process_singleton_browsertest.cc
index b818e267e7b5b21a483c9c7ebc42849bbb89b226..332b21233661da373e4deea22487f280591c3de5 100644
--- a/chrome/browser/process_singleton_browsertest.cc
+++ b/chrome/browser/process_singleton_browsertest.cc
@@ -35,12 +35,12 @@ namespace {
// base::Bind to run the StartChrome methods in many threads.
class ChromeStarter : public base::RefCountedThreadSafe<ChromeStarter> {
public:
- ChromeStarter(int timeout_ms, const FilePath& user_data_dir)
+ ChromeStarter(base::TimeDelta timeout, const FilePath& user_data_dir)
: ready_event_(false /* manual */, false /* signaled */),
done_event_(false /* manual */, false /* signaled */),
process_handle_(base::kNullProcessHandle),
process_terminated_(false),
- timeout_ms_(timeout_ms),
+ timeout_(timeout),
user_data_dir_(user_data_dir) {
}
@@ -101,7 +101,7 @@ class ChromeStarter : public base::RefCountedThreadSafe<ChromeStarter> {
// one process. The test below will take care of killing that process
// to unstuck us once it confirms there is only one.
process_terminated_ = base::WaitForSingleProcess(process_handle_,
- timeout_ms_);
+ timeout_);
// Let the test know we are done.
done_event_.Signal();
}
@@ -120,7 +120,7 @@ class ChromeStarter : public base::RefCountedThreadSafe<ChromeStarter> {
base::CloseProcessHandle(process_handle_);
}
- int timeout_ms_;
+ base::TimeDelta timeout_;
FilePath user_data_dir_;
DISALLOW_COPY_AND_ASSIGN(ChromeStarter);
@@ -144,7 +144,7 @@ class ProcessSingletonTest : public InProcessBrowserTest {
chrome_starter_threads_[i].reset(new base::Thread("ChromeStarter"));
ASSERT_TRUE(chrome_starter_threads_[i]->Start());
chrome_starters_[i] = new ChromeStarter(
- TestTimeouts::action_max_timeout_ms(), temp_profile_dir_.path());
+ TestTimeouts::action_max_timeout(), temp_profile_dir_.path());
}
}
« no previous file with comments | « no previous file | chrome/browser/process_singleton_linux_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698