Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 10704115: Switch to TimeDelta interfaces of TestTimeouts in chrome and ui code reviewable by ben. (Closed)

Created:
8 years, 5 months ago by Ted Vessenes
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Switch to TimeDelta interfaces of TestTimeouts in chrome and ui code reviewable by ben. R=ben@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M chrome/browser/process_singleton_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/process_singleton_linux_unittest.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/test/ui_cocoa_test_helper.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ted Vessenes
8 years, 5 months ago (2012-07-09 01:11:57 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-09 15:41:47 UTC) #2
Ted Vessenes
I just realized looking over this code that the WaitForSingleProcess() interface extension for windows hasn't ...
8 years, 5 months ago (2012-07-09 15:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10704115/1
8 years, 5 months ago (2012-07-09 18:26:50 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-09 19:59:26 UTC) #5
Change committed as 145729

Powered by Google App Engine
This is Rietveld 408576698