Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10704113: Make tab/tabstrip high density compatible (Closed)

Created:
8 years, 5 months ago by oshima
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make tab/tabstrip high density compatible added ImageSkiaOperations and replaced Bitmap with ImageSkiaRep/ImagSkia. BUG=122992 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145976

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -39 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 1 2 6 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 8 chunks +26 lines, -19 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
A ui/gfx/image/image_skia_operations.h View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A ui/gfx/image/image_skia_operations.cc View 1 2 3 1 chunk +167 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/glow_hover_controller.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
oshima
8 years, 5 months ago (2012-07-10 14:17:59 UTC) #1
pkotwicz
LGTM, just nits http://codereview.chromium.org/10704113/diff/14001/ui/gfx/image/image_skia_operations.cc File ui/gfx/image/image_skia_operations.cc (right): http://codereview.chromium.org/10704113/diff/14001/ui/gfx/image/image_skia_operations.cc#newcode36 ui/gfx/image/image_skia_operations.cc:36: return ImageSkiaRep(resized_bitmap, ui::SCALE_FACTOR_200P); Nit: 1 space ...
8 years, 5 months ago (2012-07-10 17:16:48 UTC) #2
oshima
all done. On 2012/07/10 17:16:48, pkotwicz wrote: > LGTM, just nits > > http://codereview.chromium.org/10704113/diff/14001/ui/gfx/image/image_skia_operations.cc > ...
8 years, 5 months ago (2012-07-10 18:25:00 UTC) #3
oshima
ben -> OWNERS
8 years, 5 months ago (2012-07-10 20:10:10 UTC) #4
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-10 20:58:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10704113/3018
8 years, 5 months ago (2012-07-10 21:02:15 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 22:53:11 UTC) #7
Change committed as 145976

Powered by Google App Engine
This is Rietveld 408576698