Issue 10704111: Allow apply_issue.py to make api calls to rietveld that don't require

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704111: Allow apply_issue.py to make api calls to rietveld that don't require (Closed)

Created:
8 years, 5 months ago by Roger Tawa OOO till Jul 10th

Modified:
8 years, 3 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Allow apply_issue.py to make api calls to rietveld that don't require authentication. Also allow apply_issue.py to specify a username and password if needed. BUG=43563 TEST=Make sure that sending try jobs directly from rietveld works.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed default for --email option #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	apply_issue.py	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
	M	rietveld.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/10704111/diff/1/apply_issue.py File apply_issue.py (right): http://codereview.chromium.org/10704111/diff/1/apply_issue.py#newcode30 apply_issue.py:30: default=None, remove default=None

8 years, 5 months ago (2012-07-06 17:15:20 UTC) #1

Roger Tawa OOO till Jul 10th

Thanks MA. Changes uploaded. http://codereview.chromium.org/10704111/diff/1/apply_issue.py File apply_issue.py (right): http://codereview.chromium.org/10704111/diff/1/apply_issue.py#newcode30 apply_issue.py:30: default=None, On 2012/07/06 17:15:20, Marc-Antoine ...

8 years, 5 months ago (2012-07-06 17:21:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10704111/3002

8 years, 5 months ago (2012-07-06 17:22:25 UTC) #3

Change committed as 145600

Expand Messages | Collapse Messages