Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10704100: Do not split attributes on getters and setters in databasebuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/systeminterface.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index caff267fe2aac21326ead60fb277981b29f64a3e..6614acbe5b461585b5ec4cbdcd7b3a7b400dbbeb 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -473,7 +473,9 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
# Constants are already defined on the interface.
pass
- def AddAttribute(self, getter, setter):
+ def AddAttribute(self, attribute):
+ getter = attribute
+ setter = attribute if not systembase.IsReadOnly(attribute) else None
if 'CheckSecurityForNode' in (getter or setter).ext_attrs:
# FIXME: exclude from interface as well.
return
@@ -489,8 +491,8 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
if setter and html_setter_name:
self._AddSetter(setter, html_setter_name)
- def AddSecondaryAttribute(self, interface, getter, setter):
- self.AddAttribute(getter, setter)
+ def AddSecondaryAttribute(self, interface, attribute):
+ self.AddAttribute(attribute)
def _AddGetter(self, attr, html_name):
type_info = GetIDLTypeInfo(attr.type.id)
« no previous file with comments | « lib/dom/scripts/systeminterface.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698