Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: lib/dom/scripts/systemfrog.py

Issue 10704100: Do not split attributes on getters and setters in databasebuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/systembase.py ('k') | lib/dom/scripts/systemhtml.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemfrog.py
diff --git a/lib/dom/scripts/systemfrog.py b/lib/dom/scripts/systemfrog.py
index 0044c0973f19a66927f0c675b1efe77144f3dbee..06ca88121d962687b2a4bd81d6662f64becbd24b 100644
--- a/lib/dom/scripts/systemfrog.py
+++ b/lib/dom/scripts/systemfrog.py
@@ -195,7 +195,9 @@ class FrogInterfaceGenerator(BaseGenerator):
def OverrideMember(self, member):
return self._interface.id + '.' + member in _dom_frog_omitted_members
- def AddAttribute(self, getter, setter):
+ def AddAttribute(self, attribute):
+ getter = attribute
+ setter = attribute if not IsReadOnly(attribute) else None
if getter and self.OverrideMember('get:' + getter.id):
getter = None
if setter and self.OverrideMember('set:' + setter.id):
@@ -312,9 +314,9 @@ class FrogInterfaceGenerator(BaseGenerator):
return FindInParent(self._interface) if attr else (None, None)
- def AddSecondaryAttribute(self, interface, getter, setter):
+ def AddSecondaryAttribute(self, interface, attribute):
self._SecondaryContext(interface)
- self.AddAttribute(getter, setter)
+ self.AddAttribute(attribute)
def AddSecondaryOperation(self, interface, info):
self._SecondaryContext(interface)
« no previous file with comments | « lib/dom/scripts/systembase.py ('k') | lib/dom/scripts/systemhtml.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698