Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: lib/dom/scripts/generator.py

Issue 10704100: Do not split attributes on getters and setters in databasebuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/databasebuilder.py ('k') | lib/dom/scripts/idlnode.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/generator.py
diff --git a/lib/dom/scripts/generator.py b/lib/dom/scripts/generator.py
index 2a8bab7544a98327368403e5c4cf80aac889055a..65b87e08714d45edf337e1a52eee606965a44d9b 100644
--- a/lib/dom/scripts/generator.py
+++ b/lib/dom/scripts/generator.py
@@ -321,9 +321,7 @@ def IsDartCollectionType(type):
def FindMatchingAttribute(interface, attr1):
matches = [attr2 for attr2 in interface.attributes
- if attr1.id == attr2.id
- and attr1.is_fc_getter == attr2.is_fc_getter
- and attr1.is_fc_setter == attr2.is_fc_setter]
+ if attr1.id == attr2.id]
if matches:
assert len(matches) == 1
return matches[0]
@@ -456,15 +454,6 @@ class OperationInfo(object):
return self.type_name
-def AttributeOutputOrder(a, b):
- """Canonical output ordering for attributes."""
- # Getters before setters:
- if a.id < b.id: return -1
- if a.id > b.id: return 1
- if a.is_fc_setter < b.is_fc_setter: return -1
- if a.is_fc_setter > b.is_fc_setter: return 1
- return 0
-
def ConstantOutputOrder(a, b):
"""Canonical output ordering for constants."""
if a.id < b.id: return -1
« no previous file with comments | « lib/dom/scripts/databasebuilder.py ('k') | lib/dom/scripts/idlnode.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698