Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 10704100: Do not split attributes on getters and setters in databasebuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/scripts/systemhtml.py
diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py
index b833bdcb8c8fe1ce52a968e4cd593df5439a7ef9..d432c32d5b5b3ac0a0fb5bc49be66af91542568e 100644
--- a/lib/dom/scripts/systemhtml.py
+++ b/lib/dom/scripts/systemhtml.py
@@ -942,7 +942,9 @@ class HtmlDartInterfaceGenerator(BaseGenerator):
self._backend.AddSecondaryMembers(self._interface)
self._backend.FinishInterface()
- def AddAttribute(self, getter, setter):
+ def AddAttribute(self, attribute):
+ getter = attribute
+ setter = attribute if not IsReadOnly(attribute) else None
dom_name = DartDomNameOfAttribute(getter)
html_getter_name = self._shared.RenameInHtmlLibrary(
self._interface.id, dom_name, 'get:')
@@ -1225,7 +1227,9 @@ class HtmlFrogClassGenerator(FrogInterfaceGenerator):
template = self._system._templates.Load(template_file)
self._members_emitter.Emit(template, E=self._shared.DartType(element_type))
- def AddAttribute(self, getter, setter):
+ def AddAttribute(self, attribute):
+ getter = attribute
+ setter = attribute if not IsReadOnly(attribute) else None
dom_name = DartDomNameOfAttribute(getter or setter)
html_getter_name = None
if not self._shared.IsCustomInHtmlLibrary(

Powered by Google App Engine
This is Rietveld 408576698