Add offline_mode support in crxless apps

Add offline_mode support in crx-less apps

Added a key in the manifest file "offline_enabled", for crx-less apps to support offline_mode.

BUG=101782
TEST=unit_test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148039

[Gaurav, 2012-07-10 18:13:33]

Added a key in the manifest file "offline_enabled", for crxless apps to support
offline_mode.

[Aaron Boodman, 2012-07-10 21:52:24]

I'm not sure if we still want to do this. Mihaip should review.

[Mihai Parparita -not on Chrome, 2012-07-11 06:03:01]

LGTM

Though I'm not sure CRX-less apps will ever graduate from chrome://flags, it's a
harmless change.

https://chromiumcodereview.appspot.com/10704092/diff/1/chrome/common/web_apps.cc
File chrome/common/web_apps.cc (right):

https://chromiumcodereview.appspot.com/10704092/diff/1/chrome/common/web_apps...
chrome/common/web_apps.cc:320: // Parse if offline mode is enabled.
This comment is redundant, and should be removed.

[Mihai Parparita -not on Chrome, 2012-07-11 06:05:27]

BTW, the "TEST=" part of the CL description is meant to contain
instructions for the QA team for how to test the change (if it needs manual
testing). In this case, since it doesn't need manual testing, you can just
omit it. See
http://dev.chromium.org/developers/contributing-code#TOC-Create-a-change-list...

Mihai

On Tue, Jul 10, 2012 at 11:03 PM, <mihaip@chromium.org> wrote:

> LGTM
>
> Though I'm not sure CRX-less apps will ever graduate from chrome://flags,
> it's a
> harmless change.
>
>
> https://chromiumcodereview.**appspot.com/10704092/diff/1/**
>
chrome/common/web_apps.cc<https://chromiumcodereview.appspot.com/10704092/diff/1/chrome/common/web_apps.cc>
> File chrome/common/web_apps.cc (right):
>
> https://chromiumcodereview.**appspot.com/10704092/diff/1/**
>
chrome/common/web_apps.cc#**newcode320<https://chromiumcodereview.appspot.com/10704092/diff/1/chrome/common/web_apps.cc#newcode320>
> chrome/common/web_apps.cc:320: // Parse if offline mode is enabled.
> This comment is redundant, and should be removed.
>
>
https://chromiumcodereview.**appspot.com/10704092/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2012-07-24 00:50:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10704092/1

[commit-bot: I haz the power, 2012-07-24 03:38:07]

Change committed as 148039