Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/expat/expat.gyp

Issue 10704079: Add a gyp flag to allow use of the system's version of libexpat (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/expat/expat.gyp
diff --git a/third_party/expat/expat.gyp b/third_party/expat/expat.gyp
index 5f9d1919906104f1f4c82a594864282d08edef87..5c7eda9f38b7df5ac64ee778e5176d7e2f82a2c8 100644
--- a/third_party/expat/expat.gyp
+++ b/third_party/expat/expat.gyp
@@ -3,6 +3,17 @@
# found in the LICENSE file.
{
+ 'variables': {
+ 'conditions': [
+ # On Linux, we implicitly already depend on expat via fontconfig;
+ # let's not pull it in twice.
+ ['os_posix == 1 and OS != "mac" and OS != "android"', {
+ 'use_system_expat%': 1,
+ }, {
+ 'use_system_expat%': 0,
+ }],
+ ],
+ },
'target_defaults': {
'defines': [
'_LIB',
@@ -11,13 +22,9 @@
'include_dirs': [
'files/lib',
],
- 'dependencies': [
- ]
},
'conditions': [
- ['os_posix == 1 and OS != "mac" and OS != "android"', {
- # On Linux, we implicitly already depend on expat via fontconfig;
- # let's not pull it in twice.
+ ['use_system_expat == 1', {
'targets': [
{
'target_name': 'expat',
@@ -27,9 +34,18 @@
'-lexpat',
],
},
+ 'conditions': [
+ ['OS=="android"', {
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '<(android_src)/external/expat/lib',
+ ],
+ },
+ }],
+ ],
},
],
- }, { # OS != linux
+ }, { # else: use_system_expat != 1
'targets': [
{
'target_name': 'expat',
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698