Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 10704078: Move quadratic behavior of Context's optimized function list verification behind --enable-slow-asse… (Closed)

Created:
8 years, 5 months ago by Jakob Kummerow
Modified:
8 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move quadratic behavior of Context's optimized function list verification behind --enable-slow-asserts flag BUG=webkit:90003 TEST=the following takes only about 1 second in debug mode: var a=[1,2,3,4,5]; eval("for (var i=0;i<50000;i++) a.sort(function(){return 1;});"); Committed: https://code.google.com/p/v8/source/detail?r=11982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/contexts.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
PTAL. I don't think we can create a regression test for this, as our test ...
8 years, 5 months ago (2012-07-03 12:54:30 UTC) #1
Michael Starzinger
8 years, 5 months ago (2012-07-03 13:00:47 UTC) #2
LGTM.

I also don't think that we need a regression test for that. Since it's neither a
functional nor a performance regression in release mode.

Powered by Google App Engine
This is Rietveld 408576698