chrome/renderer/resources/extensions/tts_engine_custom_bindings.js - Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/tts_engine_custom_bindings.js

Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tts Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/event.js ('K') | « chrome/renderer/resources/extensions/omnibox_custom_bindings.js ('k') | chrome/test/base/module_system_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/tts_engine_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/tts_engine_custom_bindings.js b/chrome/renderer/resources/extensions/tts_engine_custom_bindings.js

index 7c0067b822e9e1dd97c1a1ce87df52bc751afd8d..f16f1438e1a7491a3be40a4b22ac7bd902b77c79 100644

--- a/chrome/renderer/resources/extensions/tts_engine_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/tts_engine_custom_bindings.js

@@ -6,12 +6,13 @@

var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

-chromeHidden.registerCustomHook('ttsEngine', function() {

- chrome.ttsEngine.onSpeak.dispatch = function(text, options, requestId) {

- var sendTtsEvent = function(event) {

- chrome.ttsEngine.sendTtsEvent(requestId, event);

- };

- chrome.Event.prototype.dispatch.apply(

- this, [text, options, sendTtsEvent]);

+chromeHidden.Event.registerArgumentMassager('ttsEngine.onSpeak',

+ function(args, dispatch) {

+ var text = args[0];

+ var options = args[1];

+ var requestId = args[2];

+ var sendTtsEvent = function(event) {

+ chrome.ttsEngine.sendTtsEvent(requestId, event);

};

+ dispatch([text, options, sendTtsEvent]);

});