chrome/renderer/extensions/chrome_v8_context_set.cc - Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_context_set.cc

Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tts Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/input_ime.json ('k') | chrome/renderer/extensions/event_unittest.cc » ('j') | chrome/renderer/extensions/extension_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/chrome_v8_context_set.cc

diff --git a/chrome/renderer/extensions/chrome_v8_context_set.cc b/chrome/renderer/extensions/chrome_v8_context_set.cc

index dfe3d85fa532b03c1ffa89f8a1609598f7e8104a..808e46456f14463cb70b1d69772e59ad1ce1e180 100644

--- a/chrome/renderer/extensions/chrome_v8_context_set.cc

+++ b/chrome/renderer/extensions/chrome_v8_context_set.cc

@@ -145,15 +145,5 @@ void ChromeV8ContextSet::DispatchChromeHiddenMethod(

v8::Handle<v8::Value> retval;

(*it)->CallChromeHiddenMethod(

method_name, v8_arguments.size(), &v8_arguments[0], &retval);

- // In debug, the js will validate the event parameters and return a

- // string if a validation error has occured.

- // TODO(rafaelw): Consider only doing this check if function_name ==

- // "Event.dispatchJSON".

-#ifndef NDEBUG

- if (!retval.IsEmpty() && !retval->IsUndefined()) {

- std::string error = *v8::String::AsciiValue(retval);

- DCHECK(false) << error;

- }

-#endif

}