chrome/renderer/resources/extensions/omnibox_custom_bindings.js - Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/input.ime_custom_bindings.js ('k') | chrome/renderer/resources/extensions/tts_engine_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

index de68a764d2f0700bb7056e42b8a600906e534cb7..745010ada856efa39821127fd28476064819ab24 100644

--- a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

@@ -97,12 +97,14 @@ chromeHidden.registerCustomHook('omnibox', function(bindingsAPI) {

}

return [requestId, suggestions];

});

+});

- chrome.omnibox.onInputChanged.dispatch =

- function(text, requestId) {

- var suggestCallback = function(suggestions) {

- chrome.omnibox.sendSuggestions(requestId, suggestions);

- };

- chrome.Event.prototype.dispatch.apply(this, [text, suggestCallback]);

+chromeHidden.Event.registerArgumentMassager('omnibox.onInputChanged',

+ function(args, dispatch) {

+ var text = args[0];

+ var requestId = args[1];

+ var suggestCallback = function(suggestions) {

+ chrome.omnibox.sendSuggestions(requestId, suggestions);

};

+ dispatch([text, suggestCallback]);

});