Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2981)

Unified Diff: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

Issue 10704073: Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js b/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js
index 4ce96be9f1703e5bb55fd119976bb6ee1ef22ddf..17af969cb598bb4cd8a8ba36166fe099c4fb1d72 100644
--- a/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js
@@ -10,17 +10,22 @@ var GetExternalFileEntry = fileBrowserNatives.GetExternalFileEntry;
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
chromeHidden.Event.registerArgumentMassager('fileBrowserHandler.onExecute',
- function(args) {
- if (args.length < 2)
+ function(args, dispatch) {
+ if (args.length < 2) {
+ dispatch(args);
return;
+ }
var fileList = args[1].entries;
- if (!fileList)
+ if (!fileList) {
+ dispatch(args);
return;
+ }
// The second parameter for this event's payload is file definition
// dictionary that we used to reconstruct File API's Entry instance
// here.
for (var i = 0; i < fileList.length; i++)
fileList[i] = GetExternalFileEntry(fileList[i]);
+ dispatch(args);
});
chromeHidden.registerCustomHook('fileBrowserHandler', function(bindingsAPI) {

Powered by Google App Engine
This is Rietveld 408576698