Plumb listenerIDs correctly for events that clobber chrome.Event.prototype.dispatch.

chrome/renderer/extensions/extension_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_dispatcher.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_piece.h"
@@ skipping 190 matching lines @@
                    base::Unretained(this)));
   }
 
   v8::Handle<v8::Value> IsDevChannel(const v8::Arguments& args) {
     return v8::Boolean::New(channel_ <= chrome::VersionInfo::CHANNEL_DEV);
   }
 
   chrome::VersionInfo::Channel channel_;
 };
 
+class DebugNativeHandler : public NativeHandler {
+ public:
+  DebugNativeHandler() {
+    RouteFunction("DCHECK",
+        base::Bind(&DebugNativeHandler::Dcheck,
+                   base::Unretained(this)));
+  }
+
+  v8::Handle<v8::Value> Dcheck(const v8::Arguments& args) {
+    CHECK_LE(args.Length(), 2);
+    bool check_value = args[0]->BooleanValue();

[benwells, 2012/07/03 23:34:29]

Oh yeah, forgot to ask: Does this handle passing non-booleans into DCHECK? E.g.
if you do DCHECK(result) to make sure you have a non-null result.

[koz (OOO until 15th September), 2012/07/05 04:38:32]

This will convert any JS values to bools using the same rules that JS does.

+    std::string error_message;
+    if (args.Length() == 2)
+      error_message = *v8::String::AsciiValue(args[1]);

[not at google - send to devlin, 2012/07/03 07:47:04]

Is there a way to get a v8 stack trace in here?

[koz (OOO until 15th September), 2012/07/05 04:38:32]

Yes, it turns out. Done.

+    DCHECK(check_value) << error_message;
+    return v8::Undefined();
+  }
+};
+
 void InstallAppBindings(ModuleSystem* module_system,
                         v8::Handle<v8::Object> chrome,
                         v8::Handle<v8::Object> chrome_hidden) {
   module_system->SetLazyField(chrome, "app", "app", "chromeApp");
   module_system->SetLazyField(chrome, "appNotifications", "app",
                               "chromeAppNotifications");
   module_system->SetLazyField(chrome_hidden, "app", "app",
                               "chromeHiddenApp");
 }
 
 void InstallWebstoreBindings(ModuleSystem* module_system,
                              v8::Handle<v8::Object> chrome,
                              v8::Handle<v8::Object> chrome_hidden) {
   module_system->SetLazyField(chrome, "webstore", "webstore", "chromeWebstore");
   module_system->SetLazyField(chrome_hidden, "webstore", "webstore",
                               "chromeHiddenWebstore");
 }
 
-}
+}  // namespace
 
 ExtensionDispatcher::ExtensionDispatcher()
     : is_webkit_initialized_(false),
       webrequest_adblock_(false),
       webrequest_adblock_plus_(false),
       webrequest_other_(false),
       source_map_(&ResourceBundle::GetSharedInstance()),
       chrome_channel_(chrome::VersionInfo::CHANNEL_UNKNOWN),
       event_filter_(new extensions::EventFilter) {
   const CommandLine& command_line = *(CommandLine::ForCurrentProcess());
@@ skipping 434 matching lines @@
 
   module_system->RegisterNativeHandler("chrome_hidden",
       scoped_ptr<NativeHandler>(new ChromeHiddenNativeHandler()));
   module_system->RegisterNativeHandler("print",
       scoped_ptr<NativeHandler>(new PrintNativeHandler()));
   module_system->RegisterNativeHandler("lazy_background_page",
       scoped_ptr<NativeHandler>(new LazyBackgroundPageNativeHandler(this)));
   module_system->RegisterNativeHandler("channel",
       scoped_ptr<NativeHandler>(new ChannelNativeHandler(
           static_cast<chrome::VersionInfo::Channel>(chrome_channel_))));
+  module_system->RegisterNativeHandler("debug",
+      scoped_ptr<NativeHandler>(new DebugNativeHandler()));

[not at google - send to devlin, 2012/07/03 07:47:04]

drive-by: DCHECK is in base/logging.h, so perhaps call this module "logging"?

[koz (OOO until 15th September), 2012/07/05 04:38:32]

Done.

   // Create the 'chrome' variable if it doesn't already exist.
   {
     v8::HandleScope handle_scope;
     v8::Handle<v8::String> chrome_string(v8::String::New("chrome"));
     v8::Handle<v8::Object> global(v8::Context::GetCurrent()->Global());
     if (global->Get(chrome_string)->IsUndefined())
       global->Set(chrome_string, v8::Object::New());
   }
 
   // Loading JavaScript is expensive, so only run the full API bindings
@@ skipping 323 matching lines @@
   // APIs, they don't get extension bindings injected. If we end up here it
   // means that a sandboxed page somehow managed to invoke an API anyway, so
   // we should abort.
   WebKit::WebFrame* frame = context->web_frame();
   ExtensionURLInfo url_info(frame->document().securityOrigin(),
       UserScriptSlave::GetDataSourceURLForFrame(frame));
   CHECK(!extensions_.IsSandboxedPage(url_info));
 
   return true;
 }