Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 10704062: gdata: Get rid of chmod() system call from gdata code (Closed)

Created:
8 years, 5 months ago by yoshiki
Modified:
8 years, 5 months ago
Reviewers:
achuithb, satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Get rid of chmod() system call from gdata code BUG=134821 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146061

Patch Set 1 #

Patch Set 2 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M chrome/browser/chromeos/gdata/gdata_cache_metadata.cc View 1 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
satorux: Could you take a look? This is the gdata part of the https://chromiumcodereview.appspot.com/10696069/#ps5001.
8 years, 5 months ago (2012-07-02 19:15:57 UTC) #1
achuithb
lgtm
8 years, 5 months ago (2012-07-02 19:19:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10704062/1
8 years, 5 months ago (2012-07-03 02:30:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10704062/1
8 years, 5 months ago (2012-07-11 01:37:57 UTC) #4
commit-bot: I haz the power
Try job failure for 10704062-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-11 02:03:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10704062/12001
8 years, 5 months ago (2012-07-11 04:11:12 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 05:46:20 UTC) #7
Change committed as 146061

Powered by Google App Engine
This is Rietveld 408576698