Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4703)

Unified Diff: chrome/common/extensions/unpacker.h

Issue 10704060: Move ExtensionUnpacker into extensions:: namespace, rename it to Unpacker (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Even later master Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_unpacker_unittest.cc ('k') | chrome/common/extensions/unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/unpacker.h
diff --git a/chrome/common/extensions/extension_unpacker.h b/chrome/common/extensions/unpacker.h
similarity index 88%
rename from chrome/common/extensions/extension_unpacker.h
rename to chrome/common/extensions/unpacker.h
index 36cd551aac5a9b3323b968a02e3cbba744330666..9908165e4f99d3d3e628fea2153920508425822a 100644
--- a/chrome/common/extensions/extension_unpacker.h
+++ b/chrome/common/extensions/unpacker.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_UNPACKER_H_
-#define CHROME_COMMON_EXTENSIONS_EXTENSION_UNPACKER_H_
+#ifndef CHROME_COMMON_EXTENSIONS_UNPACKER_H_
+#define CHROME_COMMON_EXTENSIONS_UNPACKER_H_
#include <string>
#include <vector>
@@ -19,19 +19,21 @@ namespace base {
class DictionaryValue;
}
+namespace extensions {
+
// This class unpacks an extension. It is designed to be used in a sandboxed
// child process. We unpack and parse various bits of the extension, then
// report back to the browser process, who then transcodes the pre-parsed bits
// and writes them back out to disk for later use.
-class ExtensionUnpacker {
+class Unpacker {
public:
typedef std::vector< Tuple2<SkBitmap, FilePath> > DecodedImages;
- ExtensionUnpacker(const FilePath& extension_path,
- const std::string& extension_id,
- extensions::Extension::Location location,
- int creation_flags);
- ~ExtensionUnpacker();
+ Unpacker(const FilePath& extension_path,
+ const std::string& extension_id,
+ Extension::Location location,
+ int creation_flags);
+ ~Unpacker();
// Install the extension file at |extension_path|. Returns true on success.
// Otherwise, error_message will contain a string explaining what went wrong.
@@ -92,7 +94,7 @@ class ExtensionUnpacker {
std::string extension_id_;
// The location to use for the created extension.
- extensions::Extension::Location location_;
+ Extension::Location location_;
// The creation flags to use with the created extension.
int creation_flags_;
@@ -114,7 +116,9 @@ class ExtensionUnpacker {
// The last error message that was set. Empty if there were no errors.
string16 error_message_;
- DISALLOW_COPY_AND_ASSIGN(ExtensionUnpacker);
+ DISALLOW_COPY_AND_ASSIGN(Unpacker);
};
-#endif // CHROME_COMMON_EXTENSIONS_EXTENSION_UNPACKER_H_
+} // namespace extensions
+
+#endif // CHROME_COMMON_EXTENSIONS_UNPACKER_H_
« no previous file with comments | « chrome/common/extensions/extension_unpacker_unittest.cc ('k') | chrome/common/extensions/unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698