Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 10704060: Move ExtensionUnpacker into extensions:: namespace, rename it to Unpacker (Closed)

Created:
8 years, 5 months ago by Devlin
Modified:
8 years, 5 months ago
Reviewers:
Finnur
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionUnpacker into extensions:: namespace, rename it to Unpacker BUG=135462, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146853

Patch Set 1 : #

Patch Set 2 : Merged with latest master #

Patch Set 3 : Latest master for cq #

Patch Set 4 : Even later master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -721 lines) Patch
M chrome/browser/extensions/sandboxed_unpacker.h View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/extension_unpacker.h View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/common/extensions/extension_unpacker.cc View 1 chunk +0 lines, -333 lines 0 comments Download
D chrome/common/extensions/extension_unpacker_unittest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
A + chrome/common/extensions/unpacker.h View 1 2 4 chunks +15 lines, -11 lines 0 comments Download
A + chrome/common/extensions/unpacker.cc View 12 chunks +22 lines, -21 lines 0 comments Download
A + chrome/common/extensions/unpacker_unittest.cc View 1 2 12 chunks +22 lines, -19 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Devlin
Simple refactor; review would be appreciated :)
8 years, 5 months ago (2012-07-03 19:36:13 UTC) #1
Finnur
Sorry for the late reply, I've been (and still am) on vacation. LGTM.
8 years, 5 months ago (2012-07-14 11:11:34 UTC) #2
Finnur
Hmm, I've replied in Rietveld but my reply isn't being delivered in email. Weird. On ...
8 years, 5 months ago (2012-07-14 11:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10704060/12001
8 years, 5 months ago (2012-07-16 15:07:47 UTC) #4
commit-bot: I haz the power
Try job failure for 10704060-12001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-16 16:23:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10704060/19001
8 years, 5 months ago (2012-07-16 16:32:15 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-16 19:14:41 UTC) #7
Change committed as 146853

Powered by Google App Engine
This is Rietveld 408576698