Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 10704058: Fix lazy compilation for strict eval scopes. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger
Modified:
8 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix lazy compilation for strict eval scopes. This prevents lazy compilation of functions that have an outer context containing a strict eval scope. Such a scope potentially contains context allocated variables in an artificial function scope that is not deserialized correctly. R=ulan@chromium.org BUG=chromium:135066 TEST=mjsunit/regress/regress-crbug-135066 Committed: https://code.google.com/p/v8/source/detail?r=11976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -31 lines) Patch
M src/scopes.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/scopes.cc View 1 chunk +24 lines, -16 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-135066.js View 1 chunk +19 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-07-02 17:33:15 UTC) #1
ulan
8 years, 5 months ago (2012-07-03 08:39:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698