Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 10704053: Add HiDPI webstore icons. Use them on NTP and extensions domui. (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
flackr, benrg, sky
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, oshima+watch_chromium.org, brettw-cc_chromium.org, benrg
Visibility:
Public.

Description

Add HiDPI webstore icons. Use them on NTP and extensions domui. BUG=134372 TEST=none TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145332

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
D chrome/app/theme/chromium/webstore_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/chromium/webstore_icon_16.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/chromium/webstore_icon_24.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/chromium/webstore_icon_32.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/image_loading_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nico
8 years, 5 months ago (2012-06-30 01:37:20 UTC) #1
flackr
LGTM http://codereview.chromium.org/10704053/diff/1/chrome/browser/browser_resources.grd File chrome/browser/browser_resources.grd (right): http://codereview.chromium.org/10704053/diff/1/chrome/browser/browser_resources.grd#newcode25 chrome/browser/browser_resources.grd:25: <structure name="IDR_NEW_TAB_SEARCH_THEME_CSS" file="resources\ntp_search\new_tab_theme.css" flattenhtml="true" type="chrome_html" /> At some ...
8 years, 5 months ago (2012-06-30 11:45:03 UTC) #2
Nico
Does the grit exception on all the trybots look familiar to you? Any thoughts on ...
8 years, 5 months ago (2012-06-30 15:24:17 UTC) #3
flackr
+benrg, looks like it's failing on chrome_scaled_image, have you seen this before? On 2012/06/30 15:24:17, ...
8 years, 5 months ago (2012-06-30 15:27:28 UTC) #4
flackr
+benrg, looks like it's failing on chrome_scaled_image, have you seen this before? On 2012/06/30 15:24:17, ...
8 years, 5 months ago (2012-06-30 15:27:28 UTC) #5
oshima
I'm guessing that this is because trybot can't handle png file changes? On 2012/06/30 15:27:28, ...
8 years, 5 months ago (2012-06-30 15:37:52 UTC) #6
flackr
Ah yes of course! Sorry I completely overlooked that. I usually land assets ahead of ...
8 years, 5 months ago (2012-06-30 15:40:51 UTC) #7
benrg
The failure in _MakeBraceGlob (which is supposed to produce a comprehensible error message) is a ...
8 years, 5 months ago (2012-07-02 18:37:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10704053/7002
8 years, 5 months ago (2012-07-03 17:42:07 UTC) #9
commit-bot: I haz the power
Presubmit check for 10704053-7002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-03 17:42:11 UTC) #10
Nico
sky: OWNERS
8 years, 5 months ago (2012-07-03 17:42:43 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 17:42:59 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698