Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: content/shell/shell_download_manager_delegate.h

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with r148594 to and resolve conflicts with r148576 Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/mock_download_manager.h ('k') | content/shell/shell_download_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_download_manager_delegate.h
diff --git a/content/shell/shell_download_manager_delegate.h b/content/shell/shell_download_manager_delegate.h
index 36f1aa4ac302c81a4a0e24607595a2fd07484cdc..12cc5eeae64dda7cff90501b3a392b0fcbb38a07 100644
--- a/content/shell/shell_download_manager_delegate.h
+++ b/content/shell/shell_download_manager_delegate.h
@@ -21,8 +21,9 @@ class ShellDownloadManagerDelegate
void SetDownloadManager(DownloadManager* manager);
- virtual bool ShouldStartDownload(int32 download_id) OVERRIDE;
- virtual void ChooseDownloadPath(DownloadItem* item) OVERRIDE;
+ virtual bool DetermineDownloadTarget(
+ DownloadItem* download,
+ const DownloadTargetCallback& callback) OVERRIDE;
private:
friend class base::RefCountedThreadSafe<ShellDownloadManagerDelegate>;
@@ -30,9 +31,11 @@ class ShellDownloadManagerDelegate
virtual ~ShellDownloadManagerDelegate();
void GenerateFilename(int32 download_id,
+ const DownloadTargetCallback& callback,
const FilePath& generated_name);
- void RestartDownload(int32 download_id,
- const FilePath& suggested_path);
+ void ChooseDownloadPath(int32 download_id,
+ const DownloadTargetCallback& callback,
+ const FilePath& suggested_path);
DownloadManager* download_manager_;
« no previous file with comments | « content/public/test/mock_download_manager.h ('k') | content/shell/shell_download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698