Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: content/public/browser/download_manager.h

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with r148594 to and resolve conflicts with r148576 Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/download_item.h ('k') | content/public/browser/download_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index eea06be21037444a15af21a0bbce6a43ecd3f1c4..7501f0ef1dea5b153d8e47d642b4328687d1708c 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -98,12 +98,6 @@ class CONTENT_EXPORT DownloadManager
// from calling back to a stale pointer.
virtual void ManagerGoingDown(DownloadManager* manager) {}
- // Called immediately after the DownloadManager puts up a select file
- // dialog.
- // |id| indicates which download opened the dialog.
- virtual void SelectFileDialogDisplayed(
- DownloadManager* manager, int32 id) {}
-
protected:
virtual ~Observer() {}
};
@@ -134,9 +128,9 @@ class CONTENT_EXPORT DownloadManager
// to initiate the non-source portions of a download.
// Returns the id assigned to the download. If the DownloadCreateInfo
// specifies an id, that id will be used.
- virtual content::DownloadId StartDownload(
+ virtual DownloadId StartDownload(
scoped_ptr<DownloadCreateInfo> info,
- scoped_ptr<content::ByteStreamReader> stream) = 0;
+ scoped_ptr<ByteStreamReader> stream) = 0;
// Notifications sent from the download thread to the UI thread
virtual void UpdateDownload(int32 download_id,
@@ -204,19 +198,6 @@ class CONTENT_EXPORT DownloadManager
virtual BrowserContext* GetBrowserContext() const = 0;
- virtual FilePath LastDownloadPath() = 0;
-
- // Clears the last download path, used to initialize "save as" dialogs.
- virtual void ClearLastDownloadPath() = 0;
-
- // Called by the delegate after the save as dialog is closed.
- virtual void FileSelected(const FilePath& path, int32 download_id) = 0;
- virtual void FileSelectionCanceled(int32 download_id) = 0;
-
- // Called by the delegate if it delayed the download in
- // DownloadManagerDelegate::ShouldStartDownload and now is ready.
- virtual void RestartDownload(int32 download_id) = 0;
-
// Checks whether downloaded files still exist. Updates state of downloads
// that refer to removed files. The check runs in the background and may
// finish asynchronously after this method returns.
« no previous file with comments | « content/public/browser/download_item.h ('k') | content/public/browser/download_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698