Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: net/http/http_network_transaction_spdy2_unittest.cc

Issue 10704042: Fix race in HttpNetworkTransactionSpdy2Test.BasicAuthSpdyProxy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove debug lines Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_transaction_spdy3_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_spdy2_unittest.cc
===================================================================
--- net/http/http_network_transaction_spdy2_unittest.cc (revision 144483)
+++ net/http/http_network_transaction_spdy2_unittest.cc (working copy)
@@ -4943,10 +4943,10 @@
ConstructSpdyBodyFrame(3, get, strlen(get), false));
MockWrite spdy_writes[] = {
- CreateMockWrite(*req, 0, ASYNC),
- CreateMockWrite(*connect2, 2),
- CreateMockWrite(*rst, 3, ASYNC),
- CreateMockWrite(*wrapped_get, 5),
+ CreateMockWrite(*req, 1, ASYNC),
+ CreateMockWrite(*connect2, 4),
+ CreateMockWrite(*rst, 5, ASYNC),
+ CreateMockWrite(*wrapped_get, 8),
};
// The proxy responds to the connect with a 407, using a persistent
@@ -4977,11 +4977,11 @@
scoped_ptr<SpdyFrame> wrapped_body(
ConstructSpdyBodyFrame(3, "hello", 5, false));
MockRead spdy_reads[] = {
- CreateMockRead(*conn_auth_resp, 1, ASYNC),
- CreateMockRead(*conn_resp, 4, ASYNC),
- CreateMockRead(*wrapped_get_resp, 5, ASYNC),
- CreateMockRead(*wrapped_body, 6, ASYNC),
- MockRead(SYNCHRONOUS, ERR_IO_PENDING),
+ CreateMockRead(*conn_auth_resp, 2, ASYNC),
+ CreateMockRead(*conn_resp, 6, ASYNC),
+ CreateMockRead(*wrapped_get_resp, 9, ASYNC),
+ CreateMockRead(*wrapped_body, 10, ASYNC),
+ MockRead(ASYNC, OK, 11), // EOF. May or may not be read.
};
scoped_ptr<OrderedSocketData> spdy_data(
« no previous file with comments | « no previous file | net/http/http_network_transaction_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698