Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 10704040: Add an iOS section to DEPS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, cmp, Nicolas Sylvain
Base URL:
http://git.chromium.org/chromium/src.git@upstreaming-2-common-gypi
Visibility:
Public.

Description

Add an iOS section to DEPS Mostly this is to prevent checking out large parts of the tree that aren't relevant, but it also adds GTM on iOS (which we can unify with the Mac version later; I did't want to try to add rolling Mac's GTM to this process). BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M DEPS View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
If you think this is overkill we can reduce the exclusions; I know normally we ...
8 years, 5 months ago (2012-06-29 10:56:09 UTC) #1
Mark Mentovai
I guess this is OK. LGTM.
8 years, 5 months ago (2012-06-29 13:33:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10704040/1
8 years, 5 months ago (2012-06-29 21:31:12 UTC) #3
commit-bot: I haz the power
Try job failure for 10704040-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-06-29 22:07:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10704040/1
8 years, 5 months ago (2012-06-30 08:35:21 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-30 09:48:35 UTC) #6
Change committed as 145067

Powered by Google App Engine
This is Rietveld 408576698