Add iOS support to common.gypi

build/build_config.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file adds defines about the platform we're currently building on.
 //  Operating System:
 //    OS_WIN / OS_MACOSX / OS_LINUX / OS_POSIX (MACOSX or LINUX)
 //  Compiler:
 //    COMPILER_MSVC / COMPILER_GCC
 //  Processor:
 //    ARCH_CPU_X86 / ARCH_CPU_X86_64 / ARCH_CPU_X86_FAMILY (X86 or X86_64)
 //    ARCH_CPU_32_BITS / ARCH_CPU_64_BITS
 
 #ifndef BUILD_BUILD_CONFIG_H_
 #define BUILD_BUILD_CONFIG_H_
 
 // A set of macros to use for platform detection.
 #if defined(__APPLE__)
 #define OS_MACOSX 1
+#if defined(MAC_TGT_IOS)

[Mark Mentovai, 2012/06/29 13:31:25]

Who defines this?

+#define OS_IOS 1
+#endif  // defined(MAC_TGT_IOS)
 #elif defined(ANDROID)
 #define OS_ANDROID 1
 #elif defined(__native_client__)
 #define OS_NACL 1
 #elif defined(__linux__)
 #define OS_LINUX 1
 // Use TOOLKIT_GTK on linux if TOOLKIT_VIEWS isn't defined.
 #if !defined(TOOLKIT_VIEWS)
 #define TOOLKIT_GTK
 #endif
@@ skipping 62 matching lines @@
 #elif defined(_M_IX86) || defined(__i386__)
 #define ARCH_CPU_X86_FAMILY 1
 #define ARCH_CPU_X86 1
 #define ARCH_CPU_32_BITS 1
 #define ARCH_CPU_LITTLE_ENDIAN 1
 #elif defined(__ARMEL__)
 #define ARCH_CPU_ARM_FAMILY 1
 #define ARCH_CPU_ARMEL 1
 #define ARCH_CPU_32_BITS 1
 #define ARCH_CPU_LITTLE_ENDIAN 1
+#if !defined(OS_IOS)
 #define WCHAR_T_IS_UNSIGNED 1

[Mark Mentovai, 2012/06/29 13:31:25]

I don’t think this belong in this section to begin with. This section is about
CPU specifications. The type of wchar_t is at best a factor of the OS and CPU
together, and correctly belongs with the other wchar_t stuff below.

I assume that this should be defined for Android.

And the WCHAR_T_IS_UNSIGNED=0 definition in the MIPS group that follows is
almost certainly unnecessary.

[stuartmorgan, 2012/06/29 14:58:25]

Done
I have no idea; I've done it as !IOS to preserve behavior since I don't want to
accidentally break a platform I'm not familiar with.
Left a drive-by on https://chromiumcodereview.appspot.com/10448043/ but for now
I'm moving it as-is to preserve since I don't actually know or have any way to
test.

+#endif
 #elif defined(__pnacl__)
 #define ARCH_CPU_32_BITS 1
 #elif defined(__MIPSEL__)
 #define ARCH_CPU_MIPS_FAMILY 1
 #define ARCH_CPU_MIPSEL 1
 #define ARCH_CPU_32_BITS 1
 #define ARCH_CPU_LITTLE_ENDIAN 1
 #define WCHAR_T_IS_UNSIGNED 0
 #else
 #error Please add support for your architecture in build/build_config.h
@@ skipping 27 matching lines @@
 #if defined(OS_ANDROID)
 // The compiler thinks std::string::const_iterator and "const char*" are
 // equivalent types.
 #define STD_STRING_ITERATOR_IS_CHAR_POINTER
 // The compiler thinks base::string16::const_iterator and "char16*" are
 // equivalent types.
 #define BASE_STRING16_ITERATOR_IS_CHAR16_POINTER
 #endif
 
 #endif  // BUILD_BUILD_CONFIG_H_