Issue 10704038: Fix isolate build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704038: Fix isolate build. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix isolate build. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11952

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	src/d8.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/d8.cc	View		3 chunks	+3 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

8 years, 5 months ago (2012-06-29 09:12:40 UTC) #2

LGTM.

Thanks fro the fix.

http://codereview.chromium.org/10704038/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/10704038/diff/1/src/d8.cc#newcode492
src/d8.cc:492: Handle<Value> array_buffer =
global->Get(String::New("ArrayBuffer"));
I guess, since it's immutable, that is fine. Although I think that there should
be a more direct way...

Expand Messages | Collapse Messages