Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 10704036: Clean up toolchain command/option selection (Closed)

Created:
8 years, 5 months ago by Roland McGrath
Modified:
8 years, 5 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Clean up toolchain command/option selection This cleans up the selection of native-code toolchain details to be more clear and table-driven. It also drops the support for the obsolete style of tool names such as 'nacl-gcc' and 'nacl64-gcc'. This now works for the existing standard cases, and also for naclsdk_mode=custom:... specifying a next-generation toolchain that uses 'arm-nacl-...' or 'i686-nacl-...'. BUG= none TEST= trybots R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -46 lines) Patch
M site_scons/site_tools/naclsdk.py View 2 chunks +73 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roland McGrath
8 years, 5 months ago (2012-06-29 00:28:58 UTC) #1
bradn
8 years, 5 months ago (2012-06-29 16:51:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698