Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 10703191: Remove GetVolume from media::AudioRendererSink. (Closed)

Created:
8 years, 5 months ago by tommi (sloooow) - chröme
Modified:
8 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove GetVolume from media::AudioRendererSink. This was the only method that could not be implemented in an async fashion which is why a couple of implementations cached the volume in SetVolume in order to implement GetVolume. However, AudioRendererSink::GetVolume is never used, so I think it's safe to remove it and simplify the implementations a bit. If/when we need it, we should have a version that supports a callback or use the RenderCallback interface to provide the currently set volume asynchronously. AudioRendererMixerInput is the only class whose GetVolume method is being used but it's not being used via the AudioRendererSink, so I simply made GetVolume a class method and not an implementation of AudioRendererSink. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -35 lines) Patch
M content/renderer/media/audio_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/audio_device.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/media/audio_input_device.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/render_audiosourceprovider.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/media/render_audiosourceprovider.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M media/audio/null_audio_sink.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/null_audio_sink.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/audio_renderer_mixer_input.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_renderer_sink.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tommi (sloooow) - chröme
8 years, 5 months ago (2012-07-13 13:12:31 UTC) #1
DaleCurtis
On 2012/07/13 13:12:31, tommi wrote: lgtm! I'm amazed among all the uses there were no ...
8 years, 5 months ago (2012-07-14 03:41:24 UTC) #2
tommi (sloooow) - chröme
On 2012/07/14 03:41:24, DaleCurtis wrote: > On 2012/07/13 13:12:31, tommi wrote: > > lgtm! I'm ...
8 years, 5 months ago (2012-07-14 07:21:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/10703191/1
8 years, 5 months ago (2012-07-14 07:22:06 UTC) #4
commit-bot: I haz the power
Try job failure for 10703191-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-14 08:24:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/10703191/1
8 years, 5 months ago (2012-07-14 10:39:18 UTC) #6
commit-bot: I haz the power
Try job failure for 10703191-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-14 11:45:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/10703191/1
8 years, 5 months ago (2012-07-14 12:35:16 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-14 13:51:32 UTC) #9
Change committed as 146731

Powered by Google App Engine
This is Rietveld 408576698