Chromium Code Reviews
DescriptionRemove GetVolume from media::AudioRendererSink.
This was the only method that could not be implemented in an async fashion
which is why a couple of implementations cached the volume in SetVolume
in order to implement GetVolume. However, AudioRendererSink::GetVolume is
never used, so I think it's safe to remove it and simplify the implementations
a bit. If/when we need it, we should have a version that supports a callback
or use the RenderCallback interface to provide the currently set volume
asynchronously.
AudioRendererMixerInput is the only class whose GetVolume method is being used
but it's not being used via the AudioRendererSink, so I simply made GetVolume
a class method and not an implementation of AudioRendererSink.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146731
Patch Set 1 #
Messages
Total messages: 9 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||