Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(38)

Issue 10703186: Merge 122432 - [Shadow DOM] <video> with <shadow> crashes (Closed)

Created:
8 years, 7 months ago by Hajime Morrita
Modified:
8 years, 7 months ago
Reviewers:
gmorrita
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 122432 - [Shadow DOM] <video> with <shadow> crashes https://bugs.webkit.org/show_bug.cgi?id=91055 Reviewed by Kent Tamura. Source/WebCore: This is similar to Bug 90480, where an undesired renderer is created by locating an insertion point on the shadow boundary. This change adds a guard for such case by cheking whether the source node of each to-be-created renderer comes from the UA shadow tree, which is allowed to have a renderer. Test: fast/dom/shadow/insertion-point-video-crash.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::childShouldCreateRenderer): Added a check. (WebCore::HTMLMediaElement::mediaControls): Added const. (WebCore::HTMLMediaElement::hasMediaControls): Added const. * html/HTMLMediaElement.h: (HTMLMediaElement): LayoutTests: * fast/dom/shadow/insertion-point-video-crash-expected.txt: Added. * fast/dom/shadow/insertion-point-video-crash.html: Added. TBR=morrita@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5974 lines, -3 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +1721 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/insertion-point-video-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/insertion-point-video-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +4246 lines, -0 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hajime Morrita
8 years, 7 months ago (2012-07-13 02:29:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698